Fork of Monkey with fixes

Started by Xaron, June 09, 2017, 10:14:34

Previous topic - Next topic

Xaron

Hey there, I already created a fork of monkey some time ago and applied some fixes by others (pull requests) which Mark unfortunately never implemented:

https://github.com/KrautApps/monkey

Feel free to join! :)

Changelist compared to the original Monkey:

HTML5
FIX: Audio Bugfix for Samsung/Android Browser (Jochen Heizmann)
FIX: On Firefox, KeyEvents with umlauts are fireing with keycode '0'. Those events shouldn't be eated! (Jochen Heizmann)

Android
FIX: Google Playstore fix (Jochen Heizmann)
FIX: Bugfix: Samsung Galaxy S3 - Android Browser - Databuffer Boundary Bugfix (Jochen Heizmann)


MikeHart

How far do you want to take it? Do you want to actively develop it further (with the help of others, as a community effort aka Blender or similar) or just fix it here and there.

Xaron

Up to now I just wanted to fix stuff. So no new features. But I can invite as many contributors as you wish. ;)

I think this can become quite a pain if there are huge SDK changes.

Goodlookinguy

Why? I think one of my main issues with Monkey was a lack of standard code libraries. I'm more than willing to push for standard code libraries. My XAddon.basic library was created because of the lack of basic functionality.

I also know how to fix some other, way more complex, issues involving how to parse code.
I'm insane and not in a funny or good way! nrgs.org

MikeHart

@Xaron: Sounds ok. How would you go about additions/changes? I mean syntax changes should be off limits because of backwards compatiblity. Additions should be allowed if they make sense.

How about tool replacement like a different IDE?

If you want, add me for collaboration. Can you add the issues section to your github there?

Ferdi

Hi Xaron, how about something like sygem's local notification module.  It requires a change in the iOS target.

This is the module I am talking about: https://github.com/sygem/notify

This is the pull request that is required: https://github.com/blitz-research/monkey/pull/56

Do you want to merge this type of things?  Just Wondering.  Thanks

Goodlookinguy

@MikeHart I started writing a code editor last year for Monkey, but got bored as I figured it wouldn't have much purpose. Too many others and JIDE is superior to most. However, if development of this is continuing, I can cater it to this. I'm not familiar with making code editors or text editing anything, but I can learn. At least I have no issues with parsing.
I'm insane and not in a funny or good way! nrgs.org

MikeHart

@Goodlookingguy: Wrote an full featured IDE called IndeED back in the days myself. But I was rather thinking of integrating something like Atom.

Goodlookinguy

I guess that's an okay solution, but I hate most language-ambiguous IDEs. They always seem to have issues that aren't ironed out and it just ends up stressing me out more than helping.
I'm insane and not in a funny or good way! nrgs.org

Xaron

Ferdi, sure why not. Looks good actually!

Xaron

I will keep the first posting up to date with changes compared to the original monkey.

Ferdi

I think this one by Jochen Heizmann (Maverick69) is also a must.  Basically any Monkey iOS app that uses AdColony SDK (Appodeal SDK uses AdColony SDK) will crashed.

http://www.monkey-x.com/Community/posts.php?topic=10388

I am not sure if he ever created a pull request for it.  But I had to merge this manually.

Xaron

Thanks will add it! But first Mark has to upload the mojo native files which are still not there unfortunately. ;)

Goodlookinguy

I saw some talk on Discord about you worrying about breaking old code, but I have a simple solution. It's what most places do when they release updates, to attempt to prevent any issues. Make test cases for everything. If it doesn't work, you know you messed up. If it all works, then it's probably a safe bet that the changes didn't destroy anything. When I made changes I attempted to compile a WIP game I had that used every feature in Monkey, so it was a good tester.
I'm insane and not in a funny or good way! nrgs.org

MikeHart

Quote from: Xaron on June 09, 2017, 12:34:19
I will keep the first posting up to date with changes compared to the original monkey.

Good. I guess you need to changes some issues then.